-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keras-resnet to Conda #11984
Add Keras-resnet to Conda #11984
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/keras-resnet:
|
cfa3988
to
d01ba5a
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/keras-resnet:
|
d01ba5a
to
46255b4
Compare
46255b4
to
90a90d6
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/keras-resnet:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/keras-resnet:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/keras-resnet:
For recipes/keras-resnet:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/keras-resnet:
|
@conda-forge/help-python we are waiting for the maintainer to comment for step 8 |
You can add yourself as the sole maintainer. There's no need to wait for another. |
requirements: | ||
host: | ||
- python | ||
- pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you add setuptools_scm
as well?
I didn't check but could you please confirm? Because you are using the SETUPTOOLS_SCM_PRETEND_VERSION
recipes/keras-resnet/meta.yaml
Outdated
build: | ||
number: 0 | ||
script: | ||
- export SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} # [unix] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this project needs this line
- export SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} # [unix] |
recipes/keras-resnet/meta.yaml
Outdated
|
||
extra: | ||
recipe-maintainers: | ||
- '0x00b1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part here needs to be at least you, if you want to add the developers it is fine as well
But you can maintain this recipe alone if you want to
- '0x00b1' | |
- '0x00b1' | |
- henrykironde |
If you want to, next time you can use grayskull to generate the recipe for you, you may need to do some changes, but in general, it does a good job :) |
Co-authored-by: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>
Co-authored-by: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I think I have covered all |
@marcelotrevisani or @isuruf thanks for your help. This looks good to me. Thanks @henrykironde. |
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@marcelotrevisani @isuruf Thank you folks I think I have covered all the requested changes |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)