Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keras-resnet to Conda #11984

Merged
merged 13 commits into from
Jun 27, 2020
Merged

Conversation

henrykironde
Copy link
Contributor

@henrykironde henrykironde commented Jun 23, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-resnet) and found some lint.

Here's what I've got...

For recipes/keras-resnet:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@henrykironde henrykironde force-pushed the keras-resnet branch 14 times, most recently from cfa3988 to d01ba5a Compare June 23, 2020 13:31
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-resnet) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/keras-resnet:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-resnet) and found some lint.

Here's what I've got...

For recipes/keras-resnet:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-resnet) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/keras-resnet:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-resnet) and found some lint.

Here's what I've got...

For recipes/keras-resnet:

  • about/license_family 'BSD 3-Clause' not allowed. Allowed families are
    AGPL, APACHE, BSD, CC, GPL, GPL2, GPL3, LGPL, MIT, MOZILLA, NONE,
    OTHER, PROPRIETARY, PSF, and PUBLIC-DOMAIN.

For recipes/keras-resnet:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-resnet) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/keras-resnet:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@henrykironde
Copy link
Contributor Author

@conda-forge/help-python we are waiting for the maintainer to comment for step 8

@isuruf
Copy link
Member

isuruf commented Jun 23, 2020

You can add yourself as the sole maintainer. There's no need to wait for another.

requirements:
host:
- python
- pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you add setuptools_scm as well?
I didn't check but could you please confirm? Because you are using the SETUPTOOLS_SCM_PRETEND_VERSION

build:
number: 0
script:
- export SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} # [unix]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this project needs this line

Suggested change
- export SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} # [unix]


extra:
recipe-maintainers:
- '0x00b1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part here needs to be at least you, if you want to add the developers it is fine as well
But you can maintain this recipe alone if you want to

Suggested change
- '0x00b1'
- '0x00b1'
- henrykironde

@marcelotrevisani
Copy link
Member

marcelotrevisani commented Jun 24, 2020

If you want to, next time you can use grayskull to generate the recipe for you, you may need to do some changes, but in general, it does a good job :)
You can even try to use the "online" version: marcelotrevisani.com/grayskull

henrykironde and others added 2 commits June 24, 2020 08:52
Co-authored-by: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>
Co-authored-by: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-resnet) and found it was in an excellent condition.

@henrykironde
Copy link
Contributor Author

I think I have covered all

@bw4sz
Copy link
Contributor

bw4sz commented Jun 24, 2020

@marcelotrevisani or @isuruf thanks for your help. This looks good to me. Thanks @henrykironde.

recipes/keras-resnet/meta.yaml Outdated Show resolved Hide resolved
recipes/keras-resnet/meta.yaml Outdated Show resolved Hide resolved
recipes/keras-resnet/meta.yaml Outdated Show resolved Hide resolved
henrykironde and others added 4 commits June 27, 2020 12:39
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@henrykironde
Copy link
Contributor Author

@marcelotrevisani @isuruf Thank you folks I think I have covered all the requested changes

@chrisburr chrisburr merged commit a08c263 into conda-forge:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants