-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirements-detector #1221
Add requirements-detector #1221
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
5f652f5
to
fa7fe2d
Compare
about: | ||
home: https://github.com/landscapeio/requirements-detector | ||
# See issue ( https://github.com/landscapeio/requirements-detector/issues/7 ). | ||
license: GPL-2 or MIT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Licensing is unclear. Please see issue ( prospector-dev/requirements-detector#7 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was confirmed by upstream to be MIT.
fa7fe2d
to
7abfe93
Compare
7abfe93
to
f68cb70
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
version: {{ version }} | ||
|
||
source: | ||
{% set pypi_name = name.replace("_", "-") %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this.
f68cb70
to
455608c
Compare
build: | ||
- python | ||
- setuptools | ||
- astroid >=1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped this from build
.
Think this should be good too. 😄 |
|
||
about: | ||
home: https://github.com/landscapeio/requirements-detector | ||
license: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the license file was added in 0.5.2
. Will bump and adjust in the feedstock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing in PR ( #1315 ) pre-conversion.
Generated with
conda skeleton pypi
and cleaned up after.