Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snappy #193

Closed
wants to merge 15 commits into from
11 changes: 11 additions & 0 deletions recipes/snappy/bld.bat
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
cp $RECIPE_DIR/snappy.sln $SRC_DIR
cp $RECIPE_DIR/snappy.vcproj $SRC_DIR

set SLN_FILE=snappy.sln
set SLN_CFG=Release
if "%ARCH%"=="32" (set SLN_PLAT=Win32) else (set SLN_PLAT=x64)

REM Build step
devenv "%SLN_FILE%" /Build "%SLN_CFG%|%SLN_PLAT%"
if errorlevel 1 exit 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop extra newline.

7 changes: 7 additions & 0 deletions recipes/snappy/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/env bash

./autogen.sh
./configure --prefix=$PREFIX
make
make check
make install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make check?

25 changes: 25 additions & 0 deletions recipes/snappy/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{% set version = "1.1.3" %}

package:
name: snappy
version: {{ version }}

source:
git_url: https://github.com/google/snappy.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just download the tarball instead? Should be faster and may avoid a few extra configuration steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tarballs preferred over repositories?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, yes, for many reasons:

  • download size is (probably) smaller
  • tarballs + sha/md5 is a stricter definition of version than a git tag (tags can change to other revisions)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, they may have run autoconf and other things so it is simpler to build. With many google libraries the standard has been downloading gtest and gmock, though they may have tarballs where this is already done.

git_tag: {{ version }}

requirements:
build:
- msinttypes # [win]
- libtool # [unix]
- automake # [unix]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add pkg-config for Unix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, selectors.

  • 2 spaces after package name (minimum)
  • line up indentation of these selectors.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is executed by make check in build.sh. What other tests do you recommend?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With tests in make check, the tests here usually just test existence of the
libraries that should be created.

On Wed, Mar 30, 2016, 18:55 Ryan Grout notifications@github.com wrote:

In recipes/snappy/meta.yaml
#193 (comment)
:

+{% set version = "1.1.3" %}
+
+package:

  • name: snappy
  • version: {{ version }}

+source:

+requirements:

  • build:
    • msinttypes # [win]
    • libtool # [unix]
    • automake # [unix]

The test is executed by make check in build.sh. What other tests do you
recommend?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/conda-forge/staged-recipes/pull/193/files/67d524be2767352d3295d6f110c67f718cf6ebe6#r57983056

about:
home: https://github.com/google/snappy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a summary line.

license: Other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like BSD 3-Clause. Could we put that here? I know the data is licensed differently, but don't think we want to distribute that anyways.

license_file: COPYING
license_family: Other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs maintainer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again think this is BSD.


extra:
recipe-maintainers:
- groutr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me too. 😄

20 changes: 20 additions & 0 deletions recipes/snappy/snappy.sln
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@

Microsoft Visual Studio Solution File, Format Version 10.00
# Visual Studio 2008
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "snappy", "snappy.vcproj", "{9C2150BB-37DC-4D32-99F9-C76DC1A48939}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Win32 = Debug|Win32
Release|Win32 = Release|Win32
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{9C2150BB-37DC-4D32-99F9-C76DC1A48939}.Debug|Win32.ActiveCfg = Debug|Win32
{9C2150BB-37DC-4D32-99F9-C76DC1A48939}.Debug|Win32.Build.0 = Debug|Win32
{9C2150BB-37DC-4D32-99F9-C76DC1A48939}.Release|Win32.ActiveCfg = Release|Win32
{9C2150BB-37DC-4D32-99F9-C76DC1A48939}.Release|Win32.Build.0 = Release|Win32
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
EndGlobal
213 changes: 213 additions & 0 deletions recipes/snappy/snappy.vcproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,213 @@
<?xml version="1.0" encoding="Windows-1252"?>
<VisualStudioProject
ProjectType="Visual C++"
Version="9.00"
Name="snappy"
ProjectGUID="{9C2150BB-37DC-4D32-99F9-C76DC1A48939}"
RootNamespace="snappy"
Keyword="Win32Proj"
TargetFrameworkVersion="196613"
>
<Platforms>
<Platform
Name="Win32"
/>
</Platforms>
<ToolFiles>
</ToolFiles>
<Configurations>
<Configuration
Name="Debug|Win32"
OutputDirectory="$(SolutionDir)$(ConfigurationName)"
IntermediateDirectory="$(ConfigurationName)"
ConfigurationType="4"
CharacterSet="1"
>
<Tool
Name="VCPreBuildEventTool"
/>
<Tool
Name="VCCustomBuildTool"
/>
<Tool
Name="VCXMLDataGeneratorTool"
/>
<Tool
Name="VCWebServiceProxyGeneratorTool"
/>
<Tool
Name="VCMIDLTool"
/>
<Tool
Name="VCCLCompilerTool"
Optimization="0"
AdditionalIncludeDirectories="..\snappy-msvc"
PreprocessorDefinitions="WIN32;_DEBUG;_LIB"
MinimalRebuild="true"
BasicRuntimeChecks="3"
RuntimeLibrary="3"
UsePrecompiledHeader="0"
WarningLevel="3"
DebugInformationFormat="4"
/>
<Tool
Name="VCManagedResourceCompilerTool"
/>
<Tool
Name="VCResourceCompilerTool"
/>
<Tool
Name="VCPreLinkEventTool"
/>
<Tool
Name="VCLibrarianTool"
/>
<Tool
Name="VCALinkTool"
/>
<Tool
Name="VCXDCMakeTool"
/>
<Tool
Name="VCBscMakeTool"
/>
<Tool
Name="VCFxCopTool"
/>
<Tool
Name="VCPostBuildEventTool"
/>
</Configuration>
<Configuration
Name="Release|Win32"
OutputDirectory="$(SolutionDir)$(ConfigurationName)"
IntermediateDirectory="$(ConfigurationName)"
ConfigurationType="4"
CharacterSet="1"
WholeProgramOptimization="1"
>
<Tool
Name="VCPreBuildEventTool"
/>
<Tool
Name="VCCustomBuildTool"
/>
<Tool
Name="VCXMLDataGeneratorTool"
/>
<Tool
Name="VCWebServiceProxyGeneratorTool"
/>
<Tool
Name="VCMIDLTool"
/>
<Tool
Name="VCCLCompilerTool"
Optimization="2"
EnableIntrinsicFunctions="true"
AdditionalIncludeDirectories="..\snappy-msvc"
PreprocessorDefinitions="WIN32;NDEBUG;_LIB"
RuntimeLibrary="2"
EnableFunctionLevelLinking="true"
UsePrecompiledHeader="0"
WarningLevel="3"
DebugInformationFormat="3"
/>
<Tool
Name="VCManagedResourceCompilerTool"
/>
<Tool
Name="VCResourceCompilerTool"
/>
<Tool
Name="VCPreLinkEventTool"
/>
<Tool
Name="VCLibrarianTool"
/>
<Tool
Name="VCALinkTool"
/>
<Tool
Name="VCXDCMakeTool"
/>
<Tool
Name="VCBscMakeTool"
/>
<Tool
Name="VCFxCopTool"
/>
<Tool
Name="VCPostBuildEventTool"
/>
</Configuration>
</Configurations>
<References>
</References>
<Files>
<Filter
Name="Source Files"
Filter="cpp;c;cc;cxx;def;odl;idl;hpj;bat;asm;asmx"
UniqueIdentifier="{4FC737F1-C7A5-4376-A066-2A32D752A2FF}"
>
<File
RelativePath="..\snappy-c.cc"
>
</File>
<File
RelativePath="..\snappy-sinksource.cc"
>
</File>
<File
RelativePath="..\snappy-stubs-internal.cc"
>
</File>
<File
RelativePath="..\snappy.cc"
>
</File>
</Filter>
<Filter
Name="Header Files"
Filter="h;hpp;hxx;hm;inl;inc;xsd"
UniqueIdentifier="{93995380-89BD-4b04-88EB-625FBE52EBFB}"
>
<File
RelativePath="..\snappy-c.h"
>
</File>
<File
RelativePath="..\snappy-internal.h"
>
</File>
<File
RelativePath="..\snappy-sinksource.h"
>
</File>
<File
RelativePath="..\snappy-stubs-internal.h"
>
</File>
<File
RelativePath="..\snappy-stubs-public.h"
>
</File>
<File
RelativePath="..\snappy.h"
>
</File>
</Filter>
<Filter
Name="Resource Files"
Filter="rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav"
UniqueIdentifier="{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}"
>
</Filter>
<File
RelativePath=".\ReadMe.txt"
>
</File>
</Files>
<Globals>
</Globals>
</VisualStudioProject>