Add snappy #193
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| cd %SRC_DIR% | ||
| git clone https://github.com/kmanley/snappy-msvc | ||
| cd snappy-msvc | ||
|
|
||
| set SLN_FILE=snappy.sln | ||
| set SLN_CFG=Release | ||
| if "%ARCH%"=="32" (set SLN_PLAT=Win32) else (set SLN_PLAT=x64) | ||
|
|
||
| REM Build step | ||
| devenv "%SLN_FILE%" /Build "%SLN_CFG%|%SLN_PLAT%" | ||
| if errorlevel 1 exit 1 | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/bin/env bash | ||
|
|
||
| ./autogen.sh | ||
| ./configure --prefix=$PREFIX | ||
| make | ||
| make install | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| {% set version = "1.1.3" %} | ||
|
|
||
| package: | ||
| name: snappy | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| git_url: https://github.com/google/snappy.git | ||
|
There was a problem hiding this comment. Could we just download the tarball instead? Should be faster and may avoid a few extra configuration steps. There was a problem hiding this comment. Are tarballs preferred over repositories? There was a problem hiding this comment. IMHO, yes, for many reasons:
There was a problem hiding this comment. Also, they may have run |
||
| git_tag: {{ version }} | ||
|
|
||
| about: | ||
| home: https://github.com/google/snappy | ||
|
|
||
| license: Other | ||
|
There was a problem hiding this comment. Looks like BSD 3-Clause. Could we put that here? I know the data is licensed differently, but don't think we want to distribute that anyways. |
||
| license_file: COPYING | ||
| license_family: Other | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is not part of the source code.
Can we clone a specific hash? (Although it seems that nothing is updated in almost 4 years!)
PS: Maybe we should just download those files and ship with the recipe. Just adding a comment about that repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Like this. Maybe with a shallow clone too?
Not sure how I feel about this.
So, I'm almost leaning to having
snappy-msvcbroken out as its own package that just does the git clone with a sha. It feels cleaner IMHO. Maybe others have thoughts about this? @pelson?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the two important files are the
slnandvcproj.stdintcan be got from themsinttypespackage (https://github.com/conda-forge/msinttypes-feedstock). @groutr - are you happy to just copy those files into the recipe?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with copying those into the recipe.