Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verible from github release tag #26572

Merged
merged 19 commits into from
Jun 10, 2024
Merged

Conversation

dillonroach
Copy link
Contributor

@dillonroach dillonroach commented Jun 6, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/verible) and found some lint.

Here's what I've got...

For recipes/verible:

  • The recipe must have some tests.
  • If python is a host requirement, it should be a run requirement.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/verible:

  • You are setting c_stdlib_version below the current global baseline in conda-forge (10.13). If this is your intention, you also need to override MACOSX_DEPLOYMENT_TARGET (with the same value) locally.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/verible) and found some lint.

Here's what I've got...

For recipes/verible:

  • The recipe must have some tests.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/verible:

  • You are setting c_stdlib_version below the current global baseline in conda-forge (10.13). If this is your intention, you also need to override MACOSX_DEPLOYMENT_TARGET (with the same value) locally.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/verible) and found some lint.

Here's what I've got...

For recipes/verible:

  • The recipe must have some tests.

For recipes/verible:

  • You are setting c_stdlib_version below the current global baseline in conda-forge (10.13). If this is your intention, you also need to override MACOSX_DEPLOYMENT_TARGET (with the same value) locally.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/verible) and found some lint.

Here's what I've got...

For recipes/verible:

  • The recipe must have some tests.

For recipes/verible:

  • Conflicting specification for minimum macOS deployment target!
    If your conda_build_config.yaml sets MACOSX_DEPLOYMENT_TARGET, please change the name of that key to c_stdlib_version!
    Continuing with max(c_stdlib_version, MACOSX_DEPLOYMENT_TARGET).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/verible) and found some lint.

Here's what I've got...

For recipes/verible:

  • The recipe must have some tests.

For recipes/verible:

  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/verible) and found some lint.

Here's what I've got...

For recipes/verible:

  • The recipe must have some tests.

Comment on lines 28 to 31
host:
- python
run:
- python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need python here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - was able to rerun local without any python requirement and it went through all tests successfully - the build section in the source repo suggested python as required to build, so I hadn't tried yet without. Good catch @isuruf

@isuruf
Copy link
Member

isuruf commented Jun 6, 2024

Need #26578 for macos

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/verible) and found it was in an excellent condition.

@isuruf isuruf merged commit 65475cf into conda-forge:main Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants