Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for trio and async_generator #5080

Merged
merged 5 commits into from
Feb 4, 2018
Merged

Conversation

nicoddemus
Copy link
Member

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/async_generator, recipes/trio) and found some lint.

Here's what I've got...

For recipes/async_generator:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • Recipe maintainers should be a json list.
  • The recipe license should not include the word "License".

For recipes/trio:

  • The recipe license should not include the word "License".

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/async_generator, recipes/trio) and found it was in an excellent condition.

@nicoddemus
Copy link
Member Author

@conda-forge/staged-recipes I believe this is ready for review/merge. 👍

license_family: MIT
license_file: ''
summary: Async generators and context managers for Python 3.5+
description: ".. image:: https://img.shields.io/badge/chat-join%20now-blue.svg\n :target: https://gitter.im/python-trio/general\n :alt: Join chatroom\n\n.. image:: https://img.shields.io/badge/docs-read%20now-blue.svg\n\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unreadable. I would just take a paragraph or 2 and avoid the examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

@nicoddemus
Copy link
Member Author

nicoddemus commented Feb 3, 2018 via email

home: https://github.com/python-trio/async_generator
license: MIT
license_family: MIT
license_file: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a license?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened python-trio/async_generator#11 and added a link to the recipe so we can fix that in the next release.

@nicoddemus
Copy link
Member Author

@CJ-Wright @isuruf ready for another review.

@nicoddemus
Copy link
Member Author

cc @conda-forge/staged-recipes

Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments that should not prevent this from getting merged.

version: '{{ version }}'

source:
fn: '{{ name }}-{{ version }}.tar.gz'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be dropped.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


build:
number: 0
script: python setup.py install --single-version-externally-managed --record=record.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving to script: python -m pip install --no-deps --ignore-installed .. See conda-forge/conda-forge.github.io#518

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

license: MIT
license_family: MIT
# license file not available on sdist yet: https://github.com/python-trio/async_generator/pull/11
license_file: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the empty field but that does not hurt.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to leave it there so we fill it with the license file in the next release

license_family: MIT
license_file: LICENSE
summary: An async/await-native I/O library for humans and snake people
description: ".async/await-native I/O library for Python. Like all async libraries,\n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of big and with some escape characters that I don't think are needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ocefpaf
Copy link
Member

ocefpaf commented Feb 4, 2018

@nicoddemus What do you want to do about the AppVeyor failure? async_generator is noit building on py27:

Processing c:\bld\async_generator_1517761572846\work\async_generator-1.9
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "c:\users\appveyor\appdata\local\temp\1\pip-msxyjb-build\setup.py", line 1, in <module>
        from pathlib import Path
    ImportError: No module named pathlib
    
    ----------------------------------------

@nicoddemus
Copy link
Member Author

async_generator and trio are py35+ only, so they are not supposed to be built in py27. async_generator is noarch: python, which is why it fails to build on py27.

Should I make async_generator not noarch: python so it doesn't try to build on py27?

@ocefpaf
Copy link
Member

ocefpaf commented Feb 4, 2018

You can leave the noarch there and add a constraint like python >2.7 for build and run.
Pinging @jjhelmus here who suggested that just to comfirn I got it right.

@nicoddemus
Copy link
Member Author

You can leave the noarch there and add a constraint like python >2.7 for build and run.

Ahh good idea, done!

@ocefpaf ocefpaf merged commit 8b55a31 into conda-forge:master Feb 4, 2018
@nicoddemus nicoddemus deleted the trio branch February 4, 2018 19:04
@nicoddemus
Copy link
Member Author

Thanks @ocefpaf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants