Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISE recipe #5098

Closed
wants to merge 3 commits into from
Closed

Conversation

astrojuanlu
Copy link
Member

I copied the original recipe from @damianavila with minimal changes. Damián, I added you as a maintainer in case you want to be notified with changes but please don't hesitate to step down, I can take care of the conda-forge recipe if you want :)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rise) and found some lint.

Here's what I've got...

For recipes/rise:

  • The summary item is expected in the about section.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rise) and found it was in an excellent condition.

sha256: {{ sha256 }}

build:
noarch: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important change compared with the current situation where I create pkgs for each architecture.
We need extensive testing to know if we don't have problems in any of the architectures we supported.
But I am +1 on this change unless we see associated problems, it simplifies things... and conda 4.3 is old enough by now...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm not sure if noarch should be there, since there are different build scripts for each operative systems. Thoughts @conda-forge/core?

@@ -0,0 +1,2 @@
"${PYTHON}" setup.py install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not for now... but in the future we should think if this is the proper incantation, check #528 for a long discussion about that...

@@ -0,0 +1 @@
"${PREFIX}/bin/jupyter-nbextension" enable rise --py --sys-prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for now but when damianavila/RISE#342 lands, we should modify and delete this post steps, because there will be no needed anymore...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can update the recipe after that :)

Copy link
Member

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but LGTM.

@damianavila
Copy link
Member

I think this was superseded by https://github.com/conda-forge/rise-feedstock (by @ocefpaf).
Should be close this one?

@astrojuanlu
Copy link
Member Author

Oops, I was too slow on this one :) Closing!

@astrojuanlu astrojuanlu deleted the add-rise-recipe branch May 27, 2018 10:39
@ocefpaf
Copy link
Member

ocefpaf commented May 27, 2018

I think this was superseded by conda-forge/rise-feedstock (by @ocefpaf).
Should be close this one?

Actually it was not me who added that to conda-forge ;-)
But both @Juanlu001 and @damianavila are more than welcomed to become maintainers https://github.com/conda-forge/rise-feedstock there. I did add the activation scripts to that recipe but it is clear that you know more about that than me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants