gmpy2 #876
gmpy2 #876
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| - vc14 # [win and py35] | ||
| script: | ||
| - python setup.py install --shared=$PREFIX # [unix] | ||
| - python setup.py install --shared=%LIBRARY_PREFIX% # [win] |
There was a problem hiding this comment.
Is there a jinja variable to unify these two commands into one?
|
Can somebody restart the appveyor build? |
|
I'm guessing a restart is no longer necessary. Correct? |
|
Ready for review. Let's wait until travis issues are fixed for merge. |
| - vc14 # [win and py35] | ||
| script: | ||
| - python setup.py install --shared=$PREFIX # [unix] | ||
| - python setup.py build_ext -f --shared=%LIBRARY_PREFIX% -DMSC_USE_DLL=1 install # [win] |
There was a problem hiding this comment.
More for my curiosity than anything else. What does MSC_USE_DLL do?
There was a problem hiding this comment.
For Windows, when using a function from a dll you have to explicitly mark it __declspec(dllimport) in the header. This macro would turn on that feature. Otherwise it defaults to nothing, which means that the library implementing the function should be linked statically.
There was a problem hiding this comment.
So, is this handled by gmpy2 directly, by Python, or is it passed through to the compiler?
There was a problem hiding this comment.
It's passed to the compiler by distutils
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - isuruf |
There was a problem hiding this comment.
This can be done here or in the feedstock. Feel free to add @asmeurer as he has explicitly stated he would be interested in helping maintain sympy dependencies and this is one IIRC.
I'm ok with being here. Though I may not be as active just FYI.
|
LGTM. Thanks @isuruf. |
@jakirkham @asmeurer, let me know if you want to be added as maintainers.
Depends on conda-forge/mpc-feedstock#3