Added recipe for linecache2 #887

pmlandwehr · 2016-06-27T17:31:54Z

Pinging @rbtcollins in case he would like to be added as a maintainer to the linecache2 builder on conda-forge, a library of community-build conda packages - see, uh, my request at #886. If you aren't interested in helping maintain the build, that is entirely fine too.

conda-forge-linter · 2016-06-27T17:31:57Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/linecache2) and found some lint.

Here's what I've got...

For recipes/linecache2:

The recipe license cannot be unknown.

pmlandwehr · 2016-06-27T17:33:18Z

So, as per the linter, I'm not sure what license to use here. skeleton generated the PSF license, but I couldn't find a copy anywhere...

ocefpaf · 2016-06-27T17:53:17Z

@pmlandwehr see testing-cabal/linecache2#10

conda-forge-linter · 2016-06-27T18:34:09Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/linecache2) and found it was in an excellent condition.

pmlandwehr · 2016-06-27T20:39:06Z

See Issue #2 for why this build is failing. Looking at patches...

rbtcollins · 2016-06-27T23:50:24Z

No thanks, I'm not a conda user.

pmlandwehr · 2016-07-12T13:13:18Z

@ocefpaf The log for this crash-out is really interesting - guessing it's due to the build backlog.

ocefpaf · 2016-07-12T13:17:38Z

@ocefpaf The log for this crash-out is really interesting - guessing it's due to the build backlog.

Yes (and no 😄)

The the lingering recipe is just showing another bug. Can you rebase this against the latest master. (I guess there will be some other left-over recipe, but those should pass. The bob recipe was processed earlier today.)

ocefpaf · 2016-07-13T11:22:31Z

recipes/linecache2/meta.yaml

+  patches:
+    - inspect_fodder2.patch  # [not py3k]
+    - test_linecache.patch  # [not py3k]
+    # inspect_fodder2 kills the build when byte-compiling on py 2.x


I believe this is one of those things that would not happen if we were using pip to install it. This is the 3rd package in conda-forge that needs this workaround... Maybe it is time to re-visit #528

Should we send these upstream or at least raise an issue? Would be great if they make some adjustments for these issues.

ocefpaf · 2016-07-13T14:28:53Z

  File "/opt/conda/envs/_build/lib/python2.7/site-packages/linecache2/tests/inspect_fodder2.py", line 102
    def keyworded(*arg1, arg2=1):
                            ^
SyntaxError: invalid syntax

I am wrong! Thanks for trying @pmlandwehr and sorry for the trouble.

This reverts commit c0a3cef.

ocefpaf · 2016-07-13T14:52:30Z

@pmlandwehr BTW, the reference that a pip install would work is this: pexpect/pexpect#290

jakirkham · 2016-07-15T15:40:42Z

recipes/linecache2/test_linecache.patch

+
+
+class BadUnicode(GetLineTestsBadData, unittest.TestCase):
+    file_byte_string = b'\x80abc'


Are we adding new tests for them? Thoughts on this @pelson?

What about this stuff though, @pmlandwehr? Looks like an addition to me. 😕

Ah, whoops. Yeah - that's taken from the patch mentioned in this comment That patch was applied to a different commit than the current one in the base repo, so I ported those changes into a new file. That could hasn't been thoroughly reviewed; rather, I was trusting that the various adaptations were indeed necessary for providing tests missing from the original. The fact that the original patches weren't sufficient surprised me, and resulted in the commenting spree in test_linecache.py

So: before passing this on to upstream we should establish that everything in theinspect_fodder.py patch is still essential to the build.

Seems we forgot to delete the patch after we stopped using it. Proposing removal in PR ( conda-forge/linecache2-feedstock#2 ).

anguslees · 2016-07-22T04:19:05Z

The patch discussions are split across multiple lines of the change, so I'll just pull the high level discussion back up to here. What is our intention with the inspect_fodder2.py fix?

We can try to stick as close to what upstream did in http://bugs.python.org/issue24054, which is to apply the test_linecache.py patch we have here and delete inspect_fodder2.py altogether (upstream did this in a separate commit, but we can do it in the same patch)
We can try for the minimal patch to address the issue, which means something like commenting out those few lines of inspect_fodder2.py (as is done currently here), and try for a much more minimal patch to test_linecache.py.
We can try something completely different that avoids trying to byte compile inspect_fodder2.py on py2. This may be as simple as renaming the file extension (and modifying the corresponding two lines in test_linecache.py).

I feel like all of these are suggested at some point in the above discussion ;) My personal preference is for (1) sticking to upstream, as indeed I did in my own version of this recipe.

Note that none of the above discussion changes the user-visible API of the module at all. It's purely avoiding a byte-compile issue on py2 with a test data file that happened to end in .py, and never actually needed to be byte compiled (or python!).

ocefpaf · 2016-07-30T22:03:53Z

@pmlandwehr is this good to go?

ocefpaf · 2016-07-30T22:15:41Z

@pmlandwehr and @anguslees you may not need the patch with latest conda-build. See conda/conda-build#1146 (comment)

@msarahan as soon as we have a release we can test that here.

jakirkham · 2016-08-08T04:25:21Z

So conda-build version 1.21.11 is out. We could try taking these patches out and see if things just work. 🍀

pmlandwehr · 2016-08-13T23:52:26Z

Here's hoping...

pmlandwehr · 2016-08-14T00:58:35Z

Yep! All fixed, hooray.

pmlandwehr · 2016-08-16T07:03:41Z

Appveyor crash seems like a fluke. Closing and restarting...

pmlandwehr · 2016-08-16T22:56:00Z

Pinging @ocefpaf for commit.

Added recipe for linecache2

29563d9

Added PSF license

aff6785

pmlandwehr changed the title ~~Added recipe for linecache2~~ WIP: Added recipe for linecache2 Jul 7, 2016

Added patches for <py3k

e148aa1

pmlandwehr changed the title ~~WIP: Added recipe for linecache2~~ Added recipe for linecache2 Jul 12, 2016

Merge branch 'master' into linecache2

165311f

ocefpaf reviewed Jul 13, 2016
View reviewed changes

Switched to pip install

c0a3cef

Revert "Switched to pip install"

8b9466e

This reverts commit c0a3cef.

jakirkham reviewed Jul 15, 2016
View reviewed changes

jakirkham mentioned this pull request Jul 21, 2016

Import recipes from github.com/anguslees/conda-* #537

Closed

Removed patches

35d4e0b

Removed patch from repo

4c6372b

pmlandwehr closed this Aug 16, 2016

pmlandwehr reopened this Aug 16, 2016

ocefpaf merged commit 0a9c70b into conda-forge:master Aug 16, 2016

pmlandwehr deleted the linecache2 branch August 17, 2016 00:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added recipe for linecache2 #887

Added recipe for linecache2 #887

pmlandwehr commented Jun 27, 2016 •

edited

Loading

conda-forge-linter commented Jun 27, 2016

pmlandwehr commented Jun 27, 2016

ocefpaf commented Jun 27, 2016

conda-forge-linter commented Jun 27, 2016

pmlandwehr commented Jun 27, 2016 •

edited

Loading

rbtcollins commented Jun 27, 2016

pmlandwehr commented Jul 12, 2016

ocefpaf commented Jul 12, 2016

ocefpaf Jul 13, 2016

jakirkham Jul 15, 2016

ocefpaf commented Jul 13, 2016

ocefpaf commented Jul 13, 2016

jakirkham Jul 15, 2016

jakirkham Jul 18, 2016

pmlandwehr Jul 18, 2016

jakirkham Aug 22, 2016

anguslees commented Jul 22, 2016 •

edited

Loading

ocefpaf commented Jul 30, 2016

ocefpaf commented Jul 30, 2016

jakirkham commented Aug 8, 2016

pmlandwehr commented Aug 13, 2016

pmlandwehr commented Aug 14, 2016

pmlandwehr commented Aug 16, 2016

pmlandwehr commented Aug 16, 2016

Added recipe for linecache2 #887

Added recipe for linecache2 #887

Conversation

pmlandwehr commented Jun 27, 2016 • edited Loading

conda-forge-linter commented Jun 27, 2016

pmlandwehr commented Jun 27, 2016

ocefpaf commented Jun 27, 2016

conda-forge-linter commented Jun 27, 2016

pmlandwehr commented Jun 27, 2016 • edited Loading

rbtcollins commented Jun 27, 2016

pmlandwehr commented Jul 12, 2016

ocefpaf commented Jul 12, 2016

ocefpaf Jul 13, 2016

Choose a reason for hiding this comment

jakirkham Jul 15, 2016

Choose a reason for hiding this comment

ocefpaf commented Jul 13, 2016

ocefpaf commented Jul 13, 2016

jakirkham Jul 15, 2016

Choose a reason for hiding this comment

jakirkham Jul 18, 2016

Choose a reason for hiding this comment

pmlandwehr Jul 18, 2016

Choose a reason for hiding this comment

jakirkham Aug 22, 2016

Choose a reason for hiding this comment

anguslees commented Jul 22, 2016 • edited Loading

ocefpaf commented Jul 30, 2016

ocefpaf commented Jul 30, 2016

jakirkham commented Aug 8, 2016

pmlandwehr commented Aug 13, 2016

pmlandwehr commented Aug 14, 2016

pmlandwehr commented Aug 16, 2016

pmlandwehr commented Aug 16, 2016

pmlandwehr commented Jun 27, 2016 •

edited

Loading

pmlandwehr commented Jun 27, 2016 •

edited

Loading

anguslees commented Jul 22, 2016 •

edited

Loading