Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLA sort is case insensitive #104

Merged
merged 1 commit into from
Jun 2, 2023
Merged

CLA sort is case insensitive #104

merged 1 commit into from
Jun 2, 2023

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented May 17, 2023

Description

The new CLA bot workflow works great however it's initially sorting the CLA config file incorrectly to then have pre-commit reorder the file again:

initially: conda/infrastructure@3c54409
pre-commit: conda/infrastructure@b5398f8
net: https://github.com/conda/infrastructure/pull/767/files

See pre-commit hook using sorted(set(value), key=str.lower)

Resolves #105

@kenodegard kenodegard self-assigned this May 17, 2023
@kenodegard kenodegard requested a review from jezdez May 17, 2023 23:34
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 17, 2023
@kenodegard kenodegard merged commit 53b1d26 into main Jun 2, 2023
@kenodegard kenodegard deleted the sort-cla branch June 2, 2023 02:02
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CLA workflow needs to use same sort as pre-commit
3 participants