-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test compileall; only compile files in packages (not deps) #1155
Conversation
5d54901
to
9e943e4
Compare
Ping @ilanschnell - this implements your idea that we should not package .cpython-35.pyc (for example) files. It renames files and moves them one level higher, adjacent with the origin .pyc files. I welcome any feedback you might have on the implementation. |
3d4724f
to
7adb047
Compare
Current coverage is 46.5% (diff: 95.7%)@@ master #1155 diff @@
==========================================
Files 43 43
Lines 5647 5656 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2611 2630 +19
+ Misses 3036 3026 -10
Partials 0 0
|
test compileall; only compile files in packages (not deps)
@msarahan no dice with 1.21.11: https://ci.appveyor.com/project/jreback/pandas-465/build/job/yy70e82akg14my9j (also the conda-build version tag looks like a dev tag!) |
Don't worry too much about the dev tag. @ilanschnell had to patch the setup.py to use distutils in order to build it with his build system. We're working on figuring out some misbehavior with argparse and our entry points. I'll look more at your build log on the .pyc stuff, though - that really should be fixed. |
Yuck, so the error is I'm not sure how to fix this right now. Please try setting CONDA_BLD_PATH as an environment variable to some very short temporary folder (perhaps What this will do is change conda build's root folder from |
so I fixed conda-build to 1.21.7 see here and this works successfully (well we are failing but on a test now): https://ci.appveyor.com/project/jreback/pandas/build/job/q22klk7yjb0c4osl |
Ok. If you don't need any of the fixes between 1.21.7 and now, that sounds fine. I'll see about adding a test and fixing this in the meantime. |
Corrollary to #1146, plus a bit of improved consistency in terms of compiling on all Pythons. This uses py_compile in favor of compileall, and only compiles files that are fed in from
post_process