Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test compileall; only compile files in packages (not deps) #1155

Merged
merged 10 commits into from
Aug 1, 2016

Conversation

msarahan
Copy link
Contributor

Corrollary to #1146, plus a bit of improved consistency in terms of compiling on all Pythons. This uses py_compile in favor of compileall, and only compiles files that are fed in from post_process

@msarahan
Copy link
Contributor Author

Ping @ilanschnell - this implements your idea that we should not package .cpython-35.pyc (for example) files. It renames files and moves them one level higher, adjacent with the origin .pyc files.

I welcome any feedback you might have on the implementation.

@codecov-io
Copy link

Current coverage is 46.5% (diff: 95.7%)

Merging #1155 into master will increase coverage by 0.3%

@@             master      #1155   diff @@
==========================================
  Files            43         43          
  Lines          5647       5656     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2611       2630    +19   
+ Misses         3036       3026    -10   
  Partials          0          0          

Powered by Codecov. Last update bfebfa9...a94f21f

@msarahan msarahan merged commit 3149091 into conda:master Aug 1, 2016
@msarahan msarahan deleted the compileall_test_rework branch August 1, 2016 00:48
msarahan added a commit that referenced this pull request Aug 1, 2016
test compileall;  only compile files in packages (not deps)
@jreback
Copy link

jreback commented Aug 7, 2016

@msarahan no dice with 1.21.11: https://ci.appveyor.com/project/jreback/pandas-465/build/job/yy70e82akg14my9j (also the conda-build version tag looks like a dev tag!)

@msarahan
Copy link
Contributor Author

msarahan commented Aug 7, 2016

Don't worry too much about the dev tag. @ilanschnell had to patch the setup.py to use distutils in order to build it with his build system. We're working on figuring out some misbehavior with argparse and our entry points. I'll look more at your build log on the .pyc stuff, though - that really should be fixed.

@msarahan
Copy link
Contributor Author

msarahan commented Aug 7, 2016

Yuck, so the error is FileNotFoundError: [WinError 206] The filename or extension is too long - not that compiling is failing, per se, but that the compile command can't even run because we're falling afoul of Window's path length limits somehow.

I'm not sure how to fix this right now. Please try setting CONDA_BLD_PATH as an environment variable to some very short temporary folder (perhaps C:\bld?) - this might be an adequate workaround for the time being.

What this will do is change conda build's root folder from C:\Python34_64\conda-bld to c:\bld, which might help here.

@jreback
Copy link

jreback commented Aug 7, 2016

so I fixed conda-build to 1.21.7 see here and this works successfully (well we are failing but on a test now): https://ci.appveyor.com/project/jreback/pandas/build/job/q22klk7yjb0c4osl

@msarahan
Copy link
Contributor Author

msarahan commented Aug 7, 2016

Ok. If you don't need any of the fixes between 1.21.7 and now, that sounds fine. I'll see about adding a test and fixing this in the meantime.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants