Compile files ending in .py not those ending in py
#1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise files like h5copy get found and the build will fail
Current coverage is 46.6% (diff: 100%)@@ master #1163 diff @@
==========================================
Files 43 43
Lines 5672 5672
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2642 2642
Misses 3030 3030
Partials 0 0
|
|
Yikes, good catch. That was silly of me. Does it actually kill the build, though? I thought that with #1146 it would barf but not die? I'm asking because this is the difference between merging and doing another 1.21.x release, or just merging and proceeding to 2.0. |
msarahan
added a commit
to msarahan/conda-build
that referenced
this pull request
Aug 2, 2016
Compile files ending in `.py` not those ending in `py`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise files like h5copy get found and the build will fail