fix: detect VS installation directory #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This is a good consistency improvement. As far as I can tell, the environment variable stuff was working, but the manual fallback would have been broken. This makes everything work. Is that right? |
|
It's actually the other way around -- |
|
Ah, yes. Thanks for clarifying. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really fix #560.
Allow
build_vcvarsall_vs_path(v)to be invoked with VS version strings inMajor.Minorformat. Currently this function assumes that its argument is inMajorMinorformat, which is not always the case. This causes VS installation path detection to fail.