Make sure we don't use binary on EmptyType with lief #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
2 tasks
|
those failures seen seem to be unrelated to this PR |
jezdez
reviewed
May 25, 2023
There was a problem hiding this comment.
@katietz Hey Kai, thanks for the patch. h-vetinari do you think this would work as well?
Co-authored-by: Jannis Leidel <jannis@leidel.info>
This was referenced May 25, 2023
|
We also need a news file for this PR |
Fine by me!
There's a suggestion in #4808 for that that you could cherry-pick here. |
|
added an news entry for 4787 |
jezdez
approved these changes
Jun 5, 2023
jezdez
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure we don't run lief code for stuff in lief it doesn't has a binary for.
Fixes #4787
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?