Fix Travis CI for Python 3.3 and conda 4.x #812
Conversation
|
@groutr, would you mind having a look at this and if there are no issues merge it. This will fix Travis CI for conda build to work on Python 3.3 (using conda 3.x) and conda 4.x on all other platforms. |
jakirkham
changed the title
|
Passes all tests as expected. |
|
👍 |
|
So, there might be a subtle difference. Python 3.3 is should still be supported as a target (ie conda-build should be able to still build packages for python 3.3). However, it looks like conda 4.x itself has dropped support for Python 3.3 (or at least it doesn't test against 3.3). |
|
Not sure what you are proposing. The changes here do support Python 3.3 still. We just must install conda 3.x on Python 3.3 for the reasons you have mentioned. The test suite has been updated to support conda 3.x and conda 4.x. |
jakirkham
force-pushed
the
fix_ci_conda_4
branch
from
0d71d6e
to
3924a15
Compare
jakirkham
force-pushed
the
fix_ci_conda_4
branch
from
3924a15
to
7c2408f
Compare
| # Get the version of conda as the error message changed in conda 4. | ||
| set +e | ||
| echo $(conda -V 2>&1) | grep "conda 3\..*" | ||
| export IS_CONDA_3=$? |
There was a problem hiding this comment.
Switched to treat conda 3 as the special case instead of conda 4. The effect is the same.
|
The code looks good to me. Pending the CI tests, I think this is good to merge. Thanks for the investigative work. |
|
Of course. Looks like it just passed. Please let me know if there is anything else. |
Fix Travis CI for Python 3.3 and conda 4.x
|
There was a build failure on master, but it seems to be caused by too many svn requests. Should probably just rebuild it. |
Fixes #810
Includes #811
Includes #809
As of conda 4.0, Python 3.3 is not supported. However, testing continues to happen here for Python 3.3. We have added a workaround to handle installing a version of conda 3.x here for Python 3.3. Also, an error message changes in conda 4.0 so we have included a different check for that warning message. However, if conda 3.x is installed for the Python 3.3 case the old error message check is used instead.