Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing files from the file list. #118

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

xhochy
Copy link
Collaborator

@xhochy xhochy commented Jun 25, 2020

These files are only really missing if the user executed conda clean -p.

These files are only really missing if the user executed `conda clean -p`.
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 25, 2020
@mcg1969
Copy link
Contributor

mcg1969 commented Jul 3, 2020

@xhochy can you revisit this one? I'm afraid there are some nontrivial merge conflicts now. In particular, note that I created a setup_envs.bat for Windows that mirrors setup_envs.sh for Unix because I was having issues with bash on Windows.

@mcg1969
Copy link
Contributor

mcg1969 commented Jul 6, 2020

Now that we're using GitHub Actions for CI you can just delete .travis.yml. And setup_envs.bat is gone again, too; we're now back down to just setup_envs.sh. So it should be easier to merge your changes.

@mcg1969
Copy link
Contributor

mcg1969 commented Jul 6, 2020

Now that I've spent so much time wading in this, I'm actually going to propose the following: that conda pack should always be tested against its own conda installation—or more specifically, its own package cache—so that it's free to manipulate that cache however it wants to without distrupting the user's local installation.

That's effectively what I do in the GitHub Action. For the raw package build and the doc build, I'm using the worker's built-in Miniconda install. But for the testing, I'm installing our own conda environment.

That said, I'd rather not do a full conda clean in testing. Let's just delete one or two packages, like the current testing does.

@mcg1969
Copy link
Contributor

mcg1969 commented Jul 6, 2020

It doesn't even matter, actually, if the conda used to create the environment is the same as the conda used to run the test! Because the code determines the location of the cached packages by the metadata in the environment.

@mcg1969
Copy link
Contributor

mcg1969 commented Jul 7, 2020

OK, with #135 I've changed the testbed in a significant way: it now creates a full conda tree, including a root environment with conda installed, and with that conda installing the individual test environments. This is significant because it enables the testbed to control its own package cache without disrupting any other work the developer might be doing.

So with this, we can free free to remove package cache entries at will, as we now do with the Python 2.7 version of the conda_pack_test_lib2 package.

@dbast
Copy link
Member

dbast commented Feb 8, 2022

@xhochy What are your plans with this PR? What about rebasing it?

@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jul 22, 2023
@xhochy xhochy requested a review from a team as a code owner August 15, 2023 12:15
@xhochy
Copy link
Collaborator Author

xhochy commented Aug 15, 2023

Due to the merge of a very old branch, this has triggered darker for a lot of the existing codebase. Thus most of the changes are unrelated. I hope it is still reviewable.

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Aug 16, 2023
Comment on lines 19 to 21
if [[ "$CONDA_CLEAN_P" == "1" ]]; then
conda clean -apfy
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit cryptic. Can we use a word here instead of "1"?

@xhochy xhochy merged commit 577e91e into conda:main Aug 25, 2023
18 checks passed
@xhochy xhochy deleted the ignore-missing-files-conda-clean-p branch August 25, 2023 13:37
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity stale::recovered [bot] recovered after being marked as stale
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants