-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove missing files from the file list. #118
Conversation
These files are only really missing if the user executed `conda clean -p`.
@xhochy can you revisit this one? I'm afraid there are some nontrivial merge conflicts now. In particular, note that I created a |
Now that we're using GitHub Actions for CI you can just delete |
Now that I've spent so much time wading in this, I'm actually going to propose the following: that conda pack should always be tested against its own conda installation—or more specifically, its own package cache—so that it's free to manipulate that cache however it wants to without distrupting the user's local installation. That's effectively what I do in the GitHub Action. For the raw package build and the doc build, I'm using the worker's built-in Miniconda install. But for the testing, I'm installing our own conda environment. That said, I'd rather not do a full conda clean in testing. Let's just delete one or two packages, like the current testing does. |
It doesn't even matter, actually, if the |
OK, with #135 I've changed the testbed in a significant way: it now creates a full So with this, we can free free to remove package cache entries at will, as we now do with the Python 2.7 version of the |
@xhochy What are your plans with this PR? What about rebasing it? |
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
Due to the merge of a very old branch, this has triggered |
testing/setup_envs.sh
Outdated
if [[ "$CONDA_CLEAN_P" == "1" ]]; then | ||
conda clean -apfy | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit cryptic. Can we use a word here instead of "1"
?
These files are only really missing if the user executed
conda clean -p
.