-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix squashfs packaging when using --dest-prefix
#210
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @rafiyr. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
@anaconda-issue-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Bracket just the unpack generation with has_dest in Packer.finish instead of returning.
This could have used a |
--dest-prefix
Updated the title. I would suspect that we will also be using the PR titles for the changelog of the next release. |
Bracket just the unpack script generation with "has_dest" in Packer.finish instead of returning.
In the current state it doesn't actually pack anything into the squashfs images when used with --dest-prefix.