Don't render empty SDG tag list div #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
empty_sdg_tags
branch
from
c148823
to
4199cc5
Compare
javierm
force-pushed
the
empty_sdg_tags
branch
from
4199cc5
to
a2cb315
Compare
The same way we don't render empty regular tags since commit 4d27bbe. This way we avoid adding an empty `<div class="sdg-tag-list">` tag, which might have associated styles (in custom CONSUL installation styles, for instance) and thus break the layout
javierm
force-pushed
the
empty_sdg_tags
branch
from
a2cb315
to
391d108
Compare
taitus
approved these changes
Oct 4, 2021
taitus
added a commit
that referenced
this pull request
Nov 3, 2021
In this PR (#4683) a new syntax was introduced in the component specs to check that the component was not rendering. It seems interesting to add this syntax to the rest of the cases and thus unify the way we check that a component is not rendering.
taitus
added a commit
that referenced
this pull request
Nov 4, 2021
In this PR (#4683) a new syntax was introduced in the component specs to check that the component was not rendering. It seems interesting to add this syntax to the rest of the cases and thus unify the way we check that a component is not rendering.
muki
pushed a commit
to danesjenovdan/consul
that referenced
this pull request
Jan 4, 2022
In this PR (consuldemocracy#4683) a new syntax was introduced in the component specs to check that the component was not rendering. It seems interesting to add this syntax to the rest of the cases and thus unify the way we check that a component is not rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
<div class="sdg-tag-list">tag, which might have associated styles (in custom CONSUL installation styles, for instance) and thus break the layout