Switch to serde_test and drop dependency on serde_json #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @reem (I've picked a reviewer for you, use r? to override) |
|
r? @apasel422 |
|
|
||
| [dependencies] | ||
| clippy = { version = "0.*", optional = true } | ||
| serde = { version = "^0.7", optional = true } | ||
| serde_json = { version = "^0.7", optional = true } | ||
| serde_test = { version = "^0.7", optional = true } |
There was a problem hiding this comment.
Is it possible to make this a dev-dependency?
There was a problem hiding this comment.
Cargo does not support optional dev-dependencies. So I can make it a dev dependency but it would mean that serde and serde_test are compiled even when running cargo test without --features serde_impl. We had decided on this approach in #48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.