Skip to content

Commit

Permalink
clarify origin of volume_context
Browse files Browse the repository at this point in the history
The "volume context as returned by CO in CreateVolumeRequest" is
misleading in several ways:
- the volume context is return *to* the CO by the SP
- it is returned in the CreateVolumeResponse
  • Loading branch information
pohly committed Dec 19, 2019
1 parent 4731db0 commit 86b55b3
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -1207,8 +1207,8 @@ message ControllerPublishVolumeRequest {
// `Secrets Requirements` section on how to use this field.
map<string, string> secrets = 5 [(csi_secret) = true];
// Volume context as returned by CO in CreateVolumeRequest. This field
// is OPTIONAL and MUST match the volume_context of the volume
// Volume context as returned by SP in CreateVolumeResponse.Volume.volume_context.
// This field is OPTIONAL and MUST match the volume_context of the volume
// identified by `volume_id`.
map<string, string> volume_context = 6;
}
Expand Down Expand Up @@ -1312,8 +1312,8 @@ message ValidateVolumeCapabilitiesRequest {
// The ID of the volume to check. This field is REQUIRED.
string volume_id = 1;
// Volume context as returned by CO in CreateVolumeRequest. This field
// is OPTIONAL and MUST match the volume_context of the volume
// Volume context as returned by SP in CreateVolumeResponse.Volume.volume_context.
// This field is OPTIONAL and MUST match the volume_context of the volume
// identified by `volume_id`.
map<string, string> volume_context = 2;
Expand Down Expand Up @@ -1958,8 +1958,8 @@ message NodeStageVolumeRequest {
// section on how to use this field.
map<string, string> secrets = 5 [(csi_secret) = true];
// Volume context as returned by CO in CreateVolumeRequest. This field
// is OPTIONAL and MUST match the volume_context of the volume
// Volume context as returned by SP in CreateVolumeResponse.Volume.volume_context.
// This field is OPTIONAL and MUST match the volume_context of the volume
// identified by `volume_id`.
map<string, string> volume_context = 6;
}
Expand Down Expand Up @@ -2107,8 +2107,8 @@ message NodePublishVolumeRequest {
// section on how to use this field.
map<string, string> secrets = 7 [(csi_secret) = true];
// Volume context as returned by CO in CreateVolumeRequest. This field
// is OPTIONAL and MUST match the volume_context of the volume
// Volume context as returned by SP in CreateVolumeResponse.Volume.volume_context.
// This field is OPTIONAL and MUST match the volume_context of the volume
// identified by `volume_id`.
map<string, string> volume_context = 8;
}
Expand Down

0 comments on commit 86b55b3

Please sign in to comment.