Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is VERSION file necessary? #324

Open
saad-ali opened this issue Nov 12, 2018 · 3 comments
Open

Is VERSION file necessary? #324

saad-ali opened this issue Nov 12, 2018 · 3 comments

Comments

@saad-ali
Copy link
Member

Follow up from #321 (comment)

Do we still need the VERSION file? If not, lets remove it.

@saad-ali
Copy link
Member Author

Not a blocker for 1.0

@saad-ali saad-ali removed this from the v1.0 milestone Nov 12, 2018
@julian-hj
Copy link
Contributor

so....if we remove the version file, where do we maintain a record of the current version? I had the notion that folks might consume VERSION in their build scripting, given that protobuf doesn't define it.

If we were to come up with some solution for #170 then I'd agree that this file is unnecessary, but until then, I think if we get rid of it, we'd be forcing everyone to manually define the CSI version they are using, which seems a bid shady to me.

@jieyu
Copy link
Member

jieyu commented Nov 12, 2018

I think version can be derived from the tag (e.g., v0.3.0, or v1.0.0, etc.) for releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants