Fix proto filedescriptor #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 18, 2018 17:16
Generated golang bindings invoke proto.Register with a "file name" and a metadata blob. The primary goal of this change is to support protobuf reflection libraries that attempt to examine the generated metadata blobs; abbreviated file names (prior to this change set) make reflection difficult. A secondary goal is to avoid overlap with other non-fully qualified proto packages: a longer, fully qualified package root has less chance of overlapping with that of another package in the wild.
|
@julian-hj @ddebroy PTAL |
jdef
commented
Jul 18, 2018
| } | ||
|
|
||
| func init() { proto.RegisterFile("csi.proto", fileDescriptor_csi_31237507707d37ec) } | ||
| func init() { | ||
| proto.RegisterFile("github.com/container-storage-interface/spec/csi.proto", fileDescriptor_csi_88c20d68ea45d9ad) |
There was a problem hiding this comment.
This is the significant "registration" line mentioned in the commit log.
jieyu
approved these changes
Jul 18, 2018
|
LGTM. But I'm not a go expert either. |
|
Not-an-expert LGTM |
|
This isn't so much a "go expert" thing as a "golang/protobuf" thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated golang bindings invoke proto.Register with a "file name" and a metadata blob. The primary goal of this change is to support protobuf reflection libraries that attempt to examine the generated metadata blobs; abbreviated file names (prior to this change set) make reflection difficult. A secondary goal is to avoid overlap with other non-fully qualified proto packages: a longer, fully qualified package root has
less chance of overlapping with that of another package in the wild.