Disallow control characters in name fields #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we're considering limits for 1 of the name fields in the spec, should we consider a general limit for "name"-like fields throughout the spec? |
|
@jdef I think I got them all. There are only 2 name fields sent in the CO->Plugin direction. There's another name field in the Plugin->CO direction which already has very stringent restrictions. What other name-like fields did you have in mind? |
|
@bswartz I think you're right. I don't see anything else. |
jdef
approved these changes
Nov 7, 2018
julian-hj
approved these changes
Nov 7, 2018
Earlier versions of the spec put no limits on name fields, but indicate that names should be usable as identifiers on storage backends. Control characers obviously conflict with this purpose, so specify that they're prohibitted, while making it clear that all other valid Unicode strings are allowed. Fixes container-storage-interface#267
bswartz
force-pushed
the
disallow-control-characters
branch
from
8b8f44b
to
b186029
Compare
|
Rebased |
jieyu
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of the spec put no limits on name fields, but
indicate that names should be usable as identifiers on storage
backends. Control characers obviously conflict with this purpose,
so specify that they're prohibitted, while making it clear that
all other valid Unicode strings are allowed.
Fixes #267