Clarify timeout and retries #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saad-ali
commented
Nov 12, 2018
spec.md
Outdated
|
|
||
| Any of the RPCs defined in this spec MAY timeout and MAY be retried. | ||
| The CO MAY chooses the maximum time it is willing to wait for a call | ||
| and how many time it retries (these values are not a negotiated between |
spec.md
Outdated
| plugin and CO). Idempotency requirements ensure that the call continues | ||
| where it left off when retried. The only way to cancel a call is to | ||
| issue a "negation" call if one exists (for example, issue an "unpublish" | ||
| call for a pending "publish" operation, or a "delete" call for a pending |
There was a problem hiding this comment.
Use exact names: publish -> ControllerUnpublishVolume
Don't even mention delete
spec.md
Outdated
| where it left off when retried. The only way to cancel a call is to | ||
| issue a "negation" call if one exists (for example, issue an "unpublish" | ||
| call for a pending "publish" operation, or a "delete" call for a pending | ||
| "create" operation, etc.). |
There was a problem hiding this comment.
Add a comment about "sometimes CO may not be able to recover".
saad-ali
force-pushed
the
clarifyTimeouts
branch
from
1fa3541
to
b18b1ae
Compare
jieyu
approved these changes
Nov 12, 2018
saad-ali
force-pushed
the
clarifyTimeouts
branch
from
b18b1ae
to
3a642ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128