Added Nomad to Container Orchestrators #421 #422
Conversation
Added a bullet link for Nomad to the readme file linking to the information about CSI support. New feature so it may change as documentation pages are created.
There was a problem hiding this comment.
LGTM. @saad-ali @jdef @julian-hj @ddebroy can you guys take a look? this one should be quick.
|
Hi folks, I'm on the Nomad team and was prepping to make a PR myself when I saw this one. We would recommend https://nomadproject.io/docs/internals/plugins/csi/ as a better link. |
Updated link to a better reference for the integration: https://nomadproject.io/docs/internals/plugins/csi/
|
Done. Sorry I jumped the gun @tgross |
Not at all! Thanks! |
|
can this be merged now? |
|
@shantanugadgil yes. |
|
Gak! Celebrated too soon. Will wait for this to be merged! |
|
LGTM |
|
@mpron could you please sign the CLA https://github.com/container-storage-interface/spec/blob/master/CCLA.pdf and email to container-storage-interface-approvers@googlegroups.com ? |
|
@tgross I leave this to you and your team to run this up the corporate ladder. I'm definitely not the right person to sign that CLA. I'll bow out of this thread now. :) |
|
Hi @jieyu, sorry about the delay. We're still in the process of getting the CLA through our legal team. If you have time to submit the PR for us that'd be great. HashiCorp are going to continue to extend our CSI support in Nomad. So I'm sure we'll have contributions going forward anyways and our internal efforts won't be wasted even if you do so. Thanks! |
|
@tgross ok, sounds good. We'll wait for you guys to sort out the CLA then. |
|
@jieyu A signed CLA has been sent your way! |
|
Signed CLA received. Merging. |
Added a bullet link for Nomad to the readme file linking to the information about CSI support. New feature so it may change as documentation pages are created.