Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert binary build git url to https url with 'git' in path based on a option #2080

Merged
merged 1 commit into from
Jul 14, 2023
Merged

convert binary build git url to https url with 'git' in path based on a option #2080

merged 1 commit into from
Jul 14, 2023

Conversation

rcerven
Copy link
Member

@rcerven rcerven commented Jul 12, 2023 •
edited
Loading

…git url to https url with 'git' in path

  • STONEBLD-1497

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • [n/a] Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • [n/a] Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

@rcerven rcerven force-pushed the source_https branch 2 times, most recently from 5abbf9e to 412112e Compare July 12, 2023 20:44
@rcerven rcerven changed the title fetch sources plugin in source container has to convert binary build … convert binary build git url to https url with 'git' in path based on a option Jul 12, 2023
@rcerven
convert binary build git url to https url with 'git' in path based on…
90dbf7e 
… a option

* STONEBLD-1497

Signed-off-by: Robert Cerven <rcerven@redhat.com>
ben-alkov
ben-alkov reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@ben-alkov ben-alkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcerven; LGTM - do we need to mention this in docs?

@rcerven rcerven merged commit bdc5133 into containerbuildsystem:master Jul 14, 2023
13 checks passed
@rcerven
Copy link
Member Author

rcerven commented Jul 14, 2023

rn updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkdchen tkdchen tkdchen approved these changes

@ben-alkov ben-alkov ben-alkov approved these changes

@mkosiarc mkosiarc Awaiting requested review from mkosiarc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcerven @tkdchen @ben-alkov