Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(source-containers): all cachito metadata #2108

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(source-containers): all cachito metadata #2108

merged 1 commit into from
Aug 19, 2024

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Aug 16, 2024 •
edited by mkosiarc
Loading

Exporting all cachito metadata caused failure in source contianer builds as it only expected 2 archives.

STONEBLD-2655

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

chmeliik
chmeliik approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, extra testcase optional

@MartinBasti
fix(source-containers): all cachito metadata
236459c 
Exporting all cachito metadata caused failure in source contianer builds
as it only expected 2 archives.

STONEBLD-2655

Signed-off-by: Martin Basti <mbasti@redhat.com>
@MartinBasti MartinBasti merged commit 30edd31 into containerbuildsystem:master Aug 19, 2024
16 checks passed
@MartinBasti MartinBasti deleted the fix-cachito-source-container branch August 19, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkosiarc mkosiarc mkosiarc approved these changes

@chmeliik chmeliik chmeliik approved these changes

@ben-alkov ben-alkov Awaiting requested review from ben-alkov

@rcerven rcerven Awaiting requested review from rcerven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinBasti @mkosiarc @chmeliik