Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate cachito task #2118

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Sep 24, 2024

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

@MartinBasti MartinBasti changed the base branch from master to feature_cachi2 September 24, 2024 09:33
@MartinBasti MartinBasti force-pushed the separate-cachito-task branch 2 times, most recently from 2ce7583 to 7d301e1 Compare September 24, 2024 20:14
Init task contains plugins which are responsible for fetching data and
validation. It split from prebuild task. Prebuild task compared to init
task, does changes to dockerfile.

This is prerequisite for having replacebale cachito task with cachi2
task in future, as this task has to be between init and prebuild.

Parameter --platforms-result has been moved to init task from prebuild
task, as init task now runs check_and_set_platforms plugin.

STONEBLD-2587

Signed-off-by: Martin Basti <mbasti@redhat.com>
Separating resolve_remote_sources into a standalone cachito task in
binary build, to allow us replacement with cachi2 in future.

STONEBLD-2587

Signed-off-by: Martin Basti <mbasti@redhat.com>
@MartinBasti
Copy link
Contributor Author

I'll remove DO NOT MERGE commit before merging

@MartinBasti MartinBasti marked this pull request as ready for review September 26, 2024 12:20
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't expect it to work this smoothly 🌮

@MartinBasti MartinBasti merged commit 3b985d6 into containerbuildsystem:feature_cachi2 Oct 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants