[release/1.4] Fix panic in metadata content writer on copy error #6044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createAndCopy
function is only called whennw.w
is nilin order to create a new writer and prepare it. The current code
is attempting to close
nw.w
when there is a copy error. Thecorrect behavior would be to close the new writer and not touch
nw.w
.Signed-off-by: Derek McGowan derek@mcg.dev
(cherry picked from commit b9cf0d7)
Signed-off-by: Derek McGowan derek@mcg.dev