network device injector plugin #82
Conversation
aojea
force-pushed
the
network-device-injector
branch
from
a0be974
to
5d266b0
Compare
|
/assign @samuelkarp |
aojea
force-pushed
the
network-device-injector
branch
from
5d266b0
to
46a6f23
Compare
There was a problem hiding this comment.
This is a neat proof of concept! Just took a brief pass through. I'd love if we can model netdevs in the runtime spec (opencontainers/runtime-spec#1239), but in the meantime it's great to see that this approach works too.
aojea
force-pushed
the
network-device-injector
branch
2 times, most recently
from
849aa8f
to
0b32005
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 64.55% 57.31% -7.24%
==========================================
Files 10 4 -6
Lines 1845 1305 -540
==========================================
- Hits 1191 748 -443
+ Misses 503 430 -73
+ Partials 151 127 -24 ☔ View full report in Codecov by Sentry. |
aojea
force-pushed
the
network-device-injector
branch
2 times, most recently
from
04c0169
to
ca24037
Compare
The network device inject plugin allow to inject network interfaces that are present in the host to the Pods. The network interface can be renamed and a network configuration can be passed. It is important to differentiate between network interface injection and CNI, as today, CNI is used for container runtimes to provider the network configuration, it performs also the creation and the configuration of the interfaces that are injected into the Pod namespace and provide as a result some properties like the assiged IPs that are consumed later by the upstream projects like Kubernetes. Signed-off-by: Antonio Ojea <aojea@google.com>
aojea
force-pushed
the
network-device-injector
branch
from
985ad32
to
ff774e6
Compare
done, I just kept them to simplify the review, so you can see the changes :) squasshed |
The network device inject plugin allow to inject network interfaces that are present in the host to the Pods.
The network interface can be renamed and a network configuration can be passed.
It is important to differentiate between network interface injection and CNI, as today, CNI is used for container runtimes to provider the network configuration, it performs also the creation and the configuration of the interfaces that are injected into the Pod namespace and provide as a result some properties like the assiged IPs that are consumed later by the upstream projects like Kubernetes.