Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.{mod,sum}, .github: bump minimum golang version to 1.20. #88

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

klihub
Copy link
Member

@klihub klihub commented Jun 4, 2024

  • bump minimum golang version to 1.20
  • test using 1.20, 1.21, and 1.22 in CI
  • bump setup-go to v5
  • update golangci-lint and fix related linter errors

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@klihub klihub force-pushed the devel/bump-golang-1.20 branch 2 times, most recently from c7ceb92 to 97e834b Compare June 6, 2024 14:34
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

plugins/network-device-injector/go.mod Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.98%. Comparing base (53d3371) to head (6d9fd80).
Report is 8 commits behind head on main.

Current head 6d9fd80 differs from pull request most recent head 8a9d653

Please upload reports for the commit 8a9d653 to get more accurate results.

Files Patch % Lines
pkg/adaptation/result.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   64.55%   63.98%   -0.57%     
==========================================
  Files          10        4       -6     
  Lines        1845     1305     -540     
==========================================
- Hits         1191      835     -356     
+ Misses        503      356     -147     
+ Partials      151      114      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit f575c3b into containerd:main Jun 7, 2024
8 checks passed
@klihub klihub deleted the devel/bump-golang-1.20 branch June 10, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants