replace go get with go install
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
approved these changes
Oct 8, 2022
fuweid
reviewed
Oct 9, 2022
The latest version of golang.org/x/sys requires Go 1.17 and cannot be compiled with older versions of Go. github.com/vbatts/git-validation imports golang.org/x/sys and specifies a compatible version of golang.org/x/sys in its go.mod, but using `go get -u` overrides the version. Use `go install` instead, which will respect the version specified in git-validation's go.mod. Signed-off-by: Samuel Karp <samuelkarp@google.com>
samuelkarp
force-pushed
the
go-install
branch
from
a764c80
to
81d9003
Compare
akhilerm
approved these changes
Oct 13, 2022
mxpv
approved these changes
Oct 13, 2022
|
I've tagged this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of golang.org/x/sys requires Go 1.17 and cannot be compiled with older versions of Go. github.com/vbatts/git-validation imports golang.org/x/sys and specifies a compatible version of golang.org/x/sys in its go.mod, but using
go get -uoverrides the version. Usego installinstead, which will respect the version specified in git-validation's go.mod.See also vbatts/git-validation#56 and opencontainers/distribution-spec#343.