Disable broken smoke #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to better re-use common Github Action-specific helper script libraries, move them into a more promintnt location, and add a README.md Signed-off-by: Chris Evich <cevich@redhat.com>
Some users of the common library are not operating under a github actions environment. To support installation under a github actions environment while retaining that characteristic, new installer behavior is required to allow subdirectory installers to modify the environment file before "installation finished" (version file) is put in place. Add a github action common lib installer which adds it's installation directory into the system-wide environment file. Update cirrus-ci_retrospective to utilize the new github action common lib for some operations. Update unit-tests. Fix bug installing system-wide environment in Ubuntu vs Fedora Signed-off-by: Chris Evich <cevich@redhat.com>
Building container images from the PR code, and testing them is too onerous of a task to encode directly into the workflow yaml. Replace with a TODO for now, and rely on a future commit to implement this step as a proper github-action or a simple script. Signed-off-by: Chris Evich <cevich@redhat.com>
|
Failure running Cirrus-CI Retrospective Github Action failed against this PR's 0d6938e60daa6ba28fd4d0e05df8294ab62b1ced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.