args: Add and use a helper to parse file descriptors #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmander
reviewed
Dec 11, 2019
| int the_fd; | ||
|
|
||
| the_fd = strtol (arg, &endptr, 10); | ||
| if (arg[0] == 0 || endptr[0] != 0 || the_fd < 0) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Never mind, didn’t notice it was assigned to an int variable.
There was a problem hiding this comment.
Although it can still create strange truncations so I think this + long the_fd is necessary after all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure cleanup patch and should not affect anything. I was gonna use it for some other work which required yet another fd argument, but that fell through.