features: add support for potentiallyUnsafeConfigAnnotations #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haircommander
force-pushed
the
potentially_unsafe_config_annotations
branch
from
23cd2e5
to
af9b6cc
Compare
giuseppe
reviewed
Apr 2, 2024
src/libcrun/container.c
Outdated
Comment on lines
368
to
379
| "run.oci.handler", | ||
| "run.oci.systemd.subgroup", | ||
| "run.oci.mount_context_type", | ||
| "run.oci.systemd.force_cgroup_v1", | ||
| "run.oci.keep_original_groups", | ||
| "run.oci.pidfd_receiver", | ||
| "run.oci.hooks.stdout", | ||
| "run.oci.hooks.stderr", | ||
| "run.oci.seccomp.plugins", | ||
| "run.oci.seccomp.receiver", | ||
| "run.oci.seccomp_bpf_data", | ||
| "run.oci.seccomp_fail_unknown_syscall", |
There was a problem hiding this comment.
is run.oci.* a valid value?
If so, that would be better, as potentially any run.oci.* annotation can change the behavior of the runtime
There was a problem hiding this comment.
not with the asterisk, but yeah I can do a generic one
haircommander
force-pushed
the
potentially_unsafe_config_annotations
branch
2 times, most recently
from
1d6e4fb
to
2c275c4
Compare
|
could you run |
giuseppe
reviewed
Apr 10, 2024
src/libcrun/linux.c
Outdated
| @@ -3093,7 +3093,7 @@ libcrun_set_usernamespace (libcrun_container_t *container, pid_t pid, libcrun_er | |||
| return 0; | |||
| } | |||
|
|
|||
| #define CAP_TO_MASK_0(x) (1L << ((x) & 31)) | |||
| #define CAP_TO_MASK_0(x) (1L << ((x) &31)) | |||
There was a problem hiding this comment.
seems unrelated to the patchset
list generated by finding all instances of `find_annotation` Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
potentially_unsafe_config_annotations
branch
from
2c275c4
to
475a3fd
Compare
|
the failure doesn't depend on this patch, so I am merging anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list generated by finding all instances of
find_annotation(note to reviewer: I don't know if they're all unsafe and I probably will end up omitting some, per your request)