Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests, oci-tests: update npm #1455

Merged
merged 3 commits into from
Apr 24, 2024
Merged

tests, oci-tests: update npm #1455

merged 3 commits into from
Apr 24, 2024

Conversation

giuseppe
Copy link
Member

No description provided.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Member Author

let's wait for (oci-validation) to pass before merging

@flouthoc
Copy link
Collaborator

Test fails with

+ export GO111MODULE=off
+ GO111MODULE=off
+ go get -d -u github.com/opencontainers/runtime-tools
go: modules disabled by GO111MODULE=off; see 'go help modules'
+ true
+ export GOCACHE=/var/tmp/gocache
+ GOCACHE=/var/tmp/gocache
+ export TMPDIR=/var/tmp
+ TMPDIR=/var/tmp
+ export XDG_RUNTIME_DIR=/run
+ XDG_RUNTIME_DIR=/run
+ cd /root/go/src/github.com/opencontainers/runtime-tools
/usr/local/bin/run-tests.sh: line 29: cd: /root/go/src/github.com/opencontainers/runtime-tools: No such file or directory

Not sure but I think the line go get -d -u github.com/opencontainers/runtime-tools || true did not download and install the go mod correctly.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

tests are green now

@rhatdan
Copy link
Member

rhatdan commented Apr 24, 2024

LGTM

@rhatdan rhatdan merged commit d075e53 into containers:main Apr 24, 2024
35 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants