-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
podman untag: error if tag doesn't exist
Throw an error if a specified tag does not exist. Also make sure that the user input is normalized as we already do for `podman tag`. To prevent regressions, add a set of end-to-end and systemd tests. Last but not least, update the docs and add bash completions. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
- Loading branch information
Showing
7 changed files
with
127 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#!/usr/bin/env bats | ||
|
||
load helpers | ||
|
||
# helper function for "podman tag/untag" test | ||
function _tag_and_check() { | ||
local tag_as="$1" | ||
local check_as="$2" | ||
|
||
run_podman tag $IMAGE $tag_as | ||
run_podman image exists $check_as | ||
run_podman untag $IMAGE $check_as | ||
run_podman 1 image exists $check_as | ||
} | ||
|
||
@test "podman tag/untag" { | ||
# Test a fully-qualified image reference. | ||
_tag_and_check registry.com/image:latest registry.com/image:latest | ||
|
||
# Test a reference without tag and make sure ":latest" is appended. | ||
_tag_and_check registry.com/image registry.com/image:latest | ||
|
||
# Test a tagged short image and make sure "localhost/" is prepended. | ||
_tag_and_check image:latest localhost/image:latest | ||
|
||
# Test a short image without tag and make sure "localhost/" is | ||
# prepended and ":latest" is appended. | ||
_tag_and_check image localhost/image:latest | ||
|
||
# Test error case. | ||
run_podman 125 untag $IMAGE registry.com/foo:bar | ||
is "$output" "Error: \"registry.com/foo:bar\": no such tag" | ||
} | ||
|
||
# vim: filetype=sh |