[CI:DOCS] Remove "(1)" from web tab text #13440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
I haven't checked if the URL stays the same. |
eriksjolund
force-pushed
the
remove_web_tab_number
branch
2 times, most recently
from
1cd1d06
to
34405e4
Compare
* Remove the ending text "(1)" to avoid it from being displayed in the web tab title for a command man page on the web. Often such a text indicates that a web page got an update. For instance GitHub issues shows the number of new comments that have been written after the user's last visit. Fixes containers#13438 Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
eriksjolund
force-pushed
the
remove_web_tab_number
branch
from
34405e4
to
f13ca39
Compare
Luap99
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
LGTM I tested this locally.
@eriksjolund Can you remove the draft or do you want to make other changes?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eriksjolund, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@eriksjolund is this still a draft? |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
I removed the draft status. The regex seems to work for the current documentation. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
displayed in the web tab title for a command man page
on the web. Often such a text indicates that a web
page got an update. For instance GitHub issues shows
the number of new comments that have been written
after the user's last visit.
Fixes Documentation suggestion: Remove "(1)" from web tabs #13438
Signed-off-by: Erik Sjölund erik.sjolund@gmail.com