Add podman play kube --annotation #13445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
mheon
reviewed
Mar 7, 2022
pkg/bindings/play/types.go
Outdated
| @@ -7,6 +7,8 @@ import ( | |||
| //go:generate go run ../generator/generator.go KubeOptions | |||
| // KubeOptions are optional options for replaying kube YAML files | |||
| type KubeOptions struct { | |||
| // Annotations - Annotations to add to Pods | |||
| Annotations []string | |||
There was a problem hiding this comment.
Should this be map[string]string so we can parse on the frontend?
|
LGTM |
|
We intended this one for interns :( |
|
We will have plenty for interns. |
|
All kinds of red unhappiness @rhatdan, that will learn you to steal from the interns! ;^) |
Allow users to add annotions in the podman play kube command. This PR Also fixes the fact that annotations in the pod spec were not being passed down to containers. Fixes: containers#12968 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to add annotions in the podman play kube command.
This PR Also fixes the fact that annotations in the pod spec were
not being passed down to containers.
Fixes: #12968
Signed-off-by: Daniel J Walsh dwalsh@redhat.com