GA: address QA issues #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfateh
reviewed
Feb 14, 2020
lehnerm
approved these changes
Feb 14, 2020
| // filter to path with and without trailing slash if the slug doesn't end | ||
| // with a trailing slash | ||
| if (pagePath && !pagePath.endsWith('/')) { | ||
| filters = `${filters},ga:pagePath==${pagePath}/` |
There was a problem hiding this comment.
Why not just use a regex? https://developers.google.com/analytics/devguides/reporting/core/v3/reference#filters
There was a problem hiding this comment.
In case there's some special characters in the path that might mess up the regex
| return <Paragraph className={styles.lightText}>The {contentTypeName}{' '} | ||
| content type hasn't been configured for use with this app. It must | ||
| have a field of type short text and must be added to the list of | ||
| content types in this app's configuration.</Paragraph>; |
There was a problem hiding this comment.
How about we add a deeplink to the app config screen?
There was a problem hiding this comment.
currently not possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.