Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump library version #5079

Merged
merged 1 commit into from
Oct 6, 2023
Merged

chore: bump library version #5079

merged 1 commit into from
Oct 6, 2023

Conversation

lilbitner
Copy link
Contributor

@lilbitner lilbitner commented Oct 6, 2023

Purpose

To fix a build issue in the AWS Amplify app, introduced from yesterday's introduction of the integration-component-library

Approach

Attempting to resolve the build issue with a version bump. The version bump includes an adjustment of the Chart.js build.

Screenshot 2023-10-06 at 7 35 02 AM
This is the error shown in the console of the Prod Amplify app. This is referencing the LineChart packaging in the component library. I made this adjustment in the library and therefore have version bumped it. I am prioritizing fixing the build, but would like to figure out why this package is not working correctly.

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for ecommerce-app-base-components ready!

Name Link
🔨 Latest commit 97fed4e
🔍 Latest deploy log https://app.netlify.com/sites/ecommerce-app-base-components/deploys/651ff5c4a2a9e50008660e33
😎 Deploy Preview https://deploy-preview-5079--ecommerce-app-base-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lilbitner lilbitner marked this pull request as ready for review October 6, 2023 11:59
@lilbitner lilbitner requested a review from a team as a code owner October 6, 2023 11:59
Copy link
Contributor

@matthew-gordon matthew-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@lilbitner lilbitner merged commit 3885ec9 into master Oct 6, 2023
12 checks passed
@lilbitner lilbitner deleted the bump-library-version branch October 6, 2023 13:57
lilbitner added a commit that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants