Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding context to cloudinary assets #59

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Adding context to cloudinary assets #59

merged 3 commits into from
Mar 10, 2020

Conversation

davidfateh
Copy link
Contributor

@davidfateh davidfateh commented Mar 10, 2020 •
edited
Loading

This will fix #54. I don't think this will expose any PII unless someone has used these context fields to actually add some. If that is the case, we can't really account for that regardless.

@davidfateh davidfateh changed the title Update index.js Adding context to cloudinary assets Mar 10, 2020
@davidfateh davidfateh mentioned this pull request Mar 10, 2020
Closed
@davidfateh davidfateh marked this pull request as ready for review March 10, 2020 13:48
@davidfateh davidfateh merged commit 49ce7ae into master Mar 10, 2020
@davidfateh davidfateh deleted the cloudinary-metadata-fix branch March 10, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taye taye taye approved these changes

@kdamball kdamball kdamball approved these changes

@lehnerm lehnerm Awaiting requested review from lehnerm

@giotiskl giotiskl Awaiting requested review from giotiskl

@jelz jelz Awaiting requested review from jelz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloudinary integration: Metadata not coming through
3 participants
@davidfateh @taye @kdamball