feat: introduce WorkflowsChangelog & WorkflowsChangelogEntry #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaoste
force-pushed
the
feat/HOMER-567-wf-changelog
branch
from
7ce4cfd
to
2c91c4e
Compare
Chaoste
changed the title
giotiskl
reviewed
Feb 8, 2022
| import { wrapCollection } from '../common-utils' | ||
| import enhanceWithMethods from '../enhance-with-methods' | ||
|
|
||
| export type WorkflowsChangelogQueryOptions = Omit<PaginationQueryOptions, 'order'> & { |
There was a problem hiding this comment.
This has unfortunately changed a bit after the latest discussion I had with @ronaldronson . For now we agreed on this final shape:
export type WorkflowsChangelogQueryOptions = Omit<PaginationQueryOptions, 'order'> & {
'entity.sys.linkType': string
'entity.sys.id': string
'workflow.sys.id': string
}
i.e. entityId, entityType and workflowId all required params for this first iteration.
Other than this PR looks good 🔥 🏅
There was a problem hiding this comment.
You mean @ronaldronson ? :P
There was a problem hiding this comment.
You mean @ronaldronson ? :P
damn yes 😆 always tricky to find him
giotiskl
requested changes
Feb 8, 2022
giotiskl
approved these changes
Feb 8, 2022
|
🎉 This PR is included in version 7.54.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring our new WorkflowsChangelog to CMA to use it in our frontend app.
Description
We're right now implementing the API
/.../:environmentId/workflows_changelog/which is a pure read endpoint withgetManybeing the only method. It allows paginating, ordering, and filtering byworkflow/workflowDefinition/entity.Checklist (check all before merging)
When adding a new method:
./lib/export-types.ts