house-keeping & small improvements #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
axe312ger
commented
Oct 17, 2017
•
axe312ger
commented
- upgrades dependencies
- fixes several small issues I came across oktober last year
- aligns structure of CDA and CMA SDK
- Switches to codecov
axe312ger
force-pushed
the
refactor/some-stuff
branch
from
025b1cd
to
826f4ff
Compare
axe312ger
force-pushed
the
refactor/some-stuff
branch
from
826f4ff
to
ae5344d
Compare
added 6 commits
February 26, 2018 11:08
This reverts commit 927927d.
axe312ger
force-pushed
the
refactor/some-stuff
branch
from
ae30155
to
0c49781
Compare
axe312ger
changed the title
BREAKING CHANGE: Will no more work with node v4
Codecov Report
@@ Coverage Diff @@
## next #144 +/- ##
=======================================
Coverage ? 69.44%
=======================================
Files ? 23
Lines ? 4029
Branches ? 621
=======================================
Hits ? 2798
Misses ? 1231
Partials ? 0Continue to review full report at Codecov.
|
shm
reviewed
Feb 27, 2018
package.json
Outdated
| @@ -19,7 +19,7 @@ | |||
| "clean": "rimraf dist", | |||
| "build": "npm run clean && npm run build:modules && npm run build:standalone", | |||
| "build:modules": "BABEL_ENV=modules babel lib -d dist/es-modules/", | |||
| "build:standalone": "webpack && NODE_ENV=production webpack", | |||
| "build:standalone": "NODE_ENV=development webpack && NODE_ENV=production webpack", | |||
There was a problem hiding this comment.
build:standalone -> development
but build:standalone:log -> production
shm
approved these changes
Feb 27, 2018
Khaledgarbaya
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.