[fixed] Strict mode error

[grncdr]

Function declarations inside blocks is an error in strict mode. Certain versions of V8 actually notice this and throw an error.

/cc @elblivion

[grncdr]

Based on these two fixes, I think that tests are not running at all...

[elblivion]

Seems happier now, thanks! Now I'm getting this which is probably unrelated - don't know where this tap function is supposed to come from:

/Users/stanton/Code/contentful-management.js/example/clone-space.js:73
      .tap(logSummary)
       ^
TypeError: undefined is not a function

https://github.com/contentful/contentful-management.js/blob/master/example/clone-space.js#L73

[sdepold]

It would come from Bluebird which we aren't using anymore.

[elblivion]

In any case it's the getSpace doesn't seem to be working, I added some debug and it doesn't throw an error for a nonexistent space:

console.log('Getting source Space %s from %s using access token %s', sourceSpaceId, host, accessToken);
client.getSpace(sourceSpaceId)
      .catch(reportInvalidSpace);
//      .then(getDestinationSpace)
//      .tap(logSummary)
//      .spread(clone)
      //.done();

$ bash wrapper
Getting source Space obviouslyfake from api.contentful.com using access token <snip>
$ echo $?
0

[sdepold]

not needed I guess?

[grncdr]

Yeah that can be removed
On 2 Sep 2015 12:26 pm, "Sascha Depold" notifications@github.com wrote:

In example/clone-space.js
#29 (comment)
:

@@ -193,6 +196,9 @@ function clone (sourceSpace, destinationSpace) {
});
}

+function tap$ (fn) {

not needed I guess?

—
Reply to this email directly or view it on GitHub
https://github.com/contentful/contentful-management.js/pull/29/files#r38517615
.

[grncdr]

The last test run was an actual test run. There are still some issues with the test running (builds may not fail correctly) so be careful when merging PRs in the future.