Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin axios to 1.6.x and prevent dependabot from overwriting the package manifest #2257

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

t-col
Copy link
Contributor

@t-col t-col commented Jun 13, 2024

Dependabot forced an update to a known incompatible minor version (1.7.x) of axios after we had attempted to pin it at the latest known compatible version (1.6.x). This reverts that change, and also updates the dependabot config to prevent this from happening again.

@t-col t-col requested a review from a team as a code owner June 13, 2024 15:48
Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, do we need to do this elsewhere?

@t-col
Copy link
Contributor Author

t-col commented Jun 13, 2024

@mgoudy91 probably CMA, yeah. I'll get to that

@t-col t-col merged commit 5def9c0 into master Jun 13, 2024
3 checks passed
@t-col t-col deleted the fix/pin-axios branch June 13, 2024 15:57
t-col added a commit that referenced this pull request Jun 13, 2024
@contentful contentful deleted a comment from contentful-automation bot Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants