Added SelectFields Method To QueryBuilder #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added tests covering every scenario that I was thinking of * followed the spec on the API doc pages for the HTTP API * added comments in code to ensure flow is manageable * had adjusted the csproj file where the versioning system appeared to have been out of alignment. If this is not desired, I can revert that
|
resolves #221 |
|
I know originally I had mentioned reuse of the Select, but to note this supports a single call of SelectFields per QueryBuilder, but does also match the names specified in the JsonProperty attribute, and uses the MemberExpression otherwise. I did also make sure to eagerly validate the chosen items as able, so some extent of the API spec could be tested at the unit level |
|
High quality and excellent PR! Thank you @nteague22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement per the HTTP API for selecting fields
API
but with a focus of applying as much of the validation through .Net exceptions as possible -- to limit runtime errors.
The main changes were:
I did add a comment that I had noticed the csproj file had the VersionPrefix set to 4.1.1, yet was using 7.2.2 on the effective fields below that. If you have not yet tried it, managing the version with
dotnet pack -o <your_locals_folder> --version-suffix <some-word-or-number>is handy, as well as the built in tooling from MS uses VersionPrefix and VersionSuffix to generate the value as it is. The above call builds out the lib as contentful.net-7.2.2-prerelease-word.nupkg -- so producing a prerelease workflow is much less painful.I can revert that change if needed, I just figured in the very least - using VersionPrefix and VersionSuffix the way I have it allows you to avoid hard Version tagging, and run the pack workflow more automatically (being able to use the dotnet cli as well as VS)
If there are any areas I did not test well enough or any sections that would need added for documentation, I would be more than happy to amend the pull request if desired.
Thanks again!