fix: fetch all referenced entities #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Spring3
reviewed
Mar 20, 2024
| expect(mockClient.withoutLinkResolution.getEntries).toHaveBeenNthCalledWith(11, { | ||
| 'sys.id[in]': params.ids, | ||
| locale: 'en-US', | ||
| skip: 90, |
There was a problem hiding this comment.
is skip expected to be 90 here? It looks from the previous request that the fetch started from skip: 0 and limit: 20.
I thought that after an error the next request should have parameters skip: 0 and limit: 10. Unless I misunderstood something
There was a problem hiding this comment.
Ah, no, sorry, I understand it now.
100 / 10 = 10 per batch. 1 request failed , so 10 + 1 request is the last one to fetch the remaining 10 items. All good :D
Spring3
approved these changes
Mar 20, 2024
dimitrycf
added a commit
that referenced
this pull request
Mar 22, 2024
This reverts commit 099dcd6.
dimitrycf
added a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously we only fetched 100 referenced entities. So for experiences with more than 100 entities bound, we only render 100 entities.
This PR fetches all bound entities in chunks of 100.
If we encounter a response too big error during fetch, we reduce the limit and try fetching again.
Screen.Recording.2024-03-20.at.15.37.47.mov
Approach