Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test apps mobile breakpoint config [ALT-1167] #725

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

primeinteger
Copy link
Contributor

Purpose

Fixes rendering for mobile breakpoint styles in the test apps.

Approach

The mobile breakpoint definition in the test apps was using the query <360px that was lower than the previewSize 390px. Essentially telling the UI to render a 390px wide iframe preview and apply mobile styles when the viewport is below 360px.

I changed the mobile breakpoint query to <576px to match the example custom breakpoints registration

Updating Breakpoints

For experiences created with the previous breakpoint config, each dev/user will need to update their experiences using the "Update breakpoints" button that displays in the design sidebar when no component is selected:

Screenshot 2024-08-29 at 9 34 58 PM

And then "Update breakpoints" in the confirmation modal:

Screenshot 2024-08-29 at 9 35 06 PM

Once the breakpoints are updated in the experience, the mobile styles work as intended again:

Screen.Recording.2024-08-29.at.9.54.30.PM.mov

@primeinteger primeinteger requested review from a team as code owners August 30, 2024 04:11
Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
experience-builder-test-app ✅ Ready (Inspect) Visit Preview Aug 30, 2024 4:11am

@primeinteger primeinteger merged commit 258f5aa into development Aug 30, 2024
12 checks passed
@primeinteger primeinteger deleted the ALT-1167/test-app-mobile-breakpoints branch August 30, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants