Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default value for container margin to be auto left/right [ALT-1166] #726

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

chasepoirier
Copy link
Contributor

@chasepoirier chasepoirier commented Aug 30, 2024

Purpose

Second half of fixed margin for the Container component. We needed to fix the default value to be margin: 0 auto 0 auto.

Ticket: https://contentful.atlassian.net/browse/ALT-1166
Linked PR: https://github.com/contentful/user_interface/pull/23002

@chasepoirier chasepoirier requested review from a team as code owners August 30, 2024 16:42
Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
experience-builder-test-app ✅ Ready (Inspect) Visit Preview Aug 30, 2024 4:42pm

Copy link
Contributor

@primeinteger primeinteger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chasepoirier chasepoirier changed the title fix: default value for container margin to be auto left/right fix: default value for container margin to be auto left/right [ALT-1166] Aug 30, 2024
@chasepoirier chasepoirier merged commit 1344f8f into development Aug 30, 2024
12 checks passed
@chasepoirier chasepoirier deleted the ALT-1166 branch August 30, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants